netdev - RE: [Patch bpf-next v7 06/13] skmsg: use GFP_KERNEL in sk_psock_create_ingress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60622e2d9cf16_401fb208c0@john-XPS-13-9370.notmuch>
Date:   Mon, 29 Mar 2021 12:44:45 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, duanxiongchun@...edance.com,
        wangdongdong.6@...edance.com, jiang.wang@...edance.com,
        Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: RE: [Patch bpf-next v7 06/13] skmsg: use GFP_KERNEL in
 sk_psock_create_ingress_msg()

Cong Wang wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> This function is only called in process context.
> 
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Jakub Sitnicki <jakub@...udflare.com>
> Cc: Lorenz Bauer <lmb@...udflare.com>
> Signed-off-by: Cong Wang <cong.wang@...edance.com>
> ---
>  net/core/skmsg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/skmsg.c b/net/core/skmsg.c
> index d43d43905d2c..656eceab73bc 100644
> --- a/net/core/skmsg.c
> +++ b/net/core/skmsg.c
> @@ -410,7 +410,7 @@ static struct sk_msg *sk_psock_create_ingress_msg(struct sock *sk,
>  	if (!sk_rmem_schedule(sk, skb, skb->truesize))
>  		return NULL;
>  
> -	msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_ATOMIC);
> +	msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_KERNEL);
>  	if (unlikely(!msg))
>  		return NULL;
>  
> -- 
> 2.25.1
> 

Acked-by: John Fastabend <john.fastabend@...il.com>