netdev - Re: [PATCH net v2] net: let skb_orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4db3b5d8-e809-498c-a516-0e10c246619a@gmail.com>
Date:   Tue, 30 Mar 2021 19:09:58 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net v2] net: let skb_orphan_partial wake-up waiters.



On 3/30/21 6:43 PM, Paolo Abeni wrote:
> Currently the mentioned helper can end-up freeing the socket wmem
> without waking-up any processes waiting for more write memory.
> 
> If the partially orphaned skb is attached to an UDP (or raw) socket,
> the lack of wake-up can hang the user-space.
> 
> Even for TCP sockets not calling the sk destructor could have bad
> effects on TSQ.
> 
> Address the issue using skb_orphan to release the sk wmem before
> setting the new sock_efree destructor. Additionally bundle the
> whole ownership update in a new helper, so that later other
> potential users could avoid duplicate code.
> 
> v1 -> v2:
>  - use skb_orphan() instead of sort of open coding it (Eric)
>  - provide an helper for the ownership change (Eric)
> 
> Fixes: f6ba8d33cfbb ("netem: fix skb_orphan_partial()")
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !