netdev - Re: [PATCH net-next] net: fix icmp_echo_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL=LDk4c1YX2MzmauvsRo_XYsO72wRwjX_swDS0N7c7pg@mail.gmail.com>
Date:   Tue, 30 Mar 2021 23:09:21 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Andreas Roeseler <andreas.a.roeseler@...il.com>
Subject: Re: [PATCH net-next] net: fix icmp_echo_enable_probe sysctl

On Tue, Mar 30, 2021 at 11:06 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> sysctl_icmp_echo_enable_probe is an u8.
>
> ipv4_net_table entry should use
>  .maxlen       = sizeof(u8).
>  .proc_handler = proc_dou8vec_minmax,
>
I should have added the following tag :

Fixes: f1b8fa9fa586 ("net: add sysctl for enabling RFC 8335 PROBE messages")

> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Andreas Roeseler <andreas.a.roeseler@...il.com>
> ---
>  net/ipv4/sysctl_net_ipv4.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index e3cb2d96b55e99f4322a99abb6a6da866dffcf4d..9199f507a005efc3f57ca0225d3898bfa5d01c53 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
> @@ -601,9 +601,9 @@ static struct ctl_table ipv4_net_table[] = {
>         {
>                 .procname       = "icmp_echo_enable_probe",
>                 .data           = &init_net.ipv4.sysctl_icmp_echo_enable_probe,
> -               .maxlen         = sizeof(int),
> +               .maxlen         = sizeof(u8),
>                 .mode           = 0644,
> -               .proc_handler   = proc_dointvec_minmax,
> +               .proc_handler   = proc_dou8vec_minmax,
>                 .extra1         = SYSCTL_ZERO,
>                 .extra2         = SYSCTL_ONE
>         },
> --
> 2.31.0.291.g576ba9dcdaf-goog
>