netdev - Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c6989a1-614e-23af-dc90-58663aa7d9a1@huawei.com>
Date:   Tue, 30 Mar 2021 15:00:05 +0800
From:   "zhangjianhua (E)" <zhangjianhua18@...wei.com>
To:     Pavel Machek <pavel@....cz>
CC:     "ath9k-devel@....qualcomm.com" <ath9k-devel@....qualcomm.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Chenyi (Johnny)" <johnny.chenyi@...wei.com>
Subject: Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

hello Pavel，thanks for your reply.

for  the a point, I don't know the led lists and cannot find it.

for the b point, I look other configs who select LEDS_CLASS, almost all 
of them select NEW_LEDS，maybe you are right, CONFIG_ATH9K also need 
select NEW_LEDS too.


Best regards,

Zhang Jianhua

在 2021/3/28 6:38, Pavel Machek 写道:
> On Fri 2021-03-26 16:13:51, Zhang Jianhua wrote:
>> If CONFIG_ATH9K=y, the following errors will be seen while compiling
>> gpio.c
>>
>> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
>> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
>> gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
>> against undefined symbol `led_classdev_unregister'
>> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
>> gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
>> gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
>> against undefined symbol `led_classdev_register_ext'
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zhang Jianhua <zhangjianhua18@...wei.com>
> a) please cc led lists with led issue.
>
> b) probably does not work as LED_CLASS depends on NEW_LEDS...?
>
> Best regards,
> 									Pavel
>