netdev - Re: [PATCHv4 1/4] usbnet: add _mii suffix to usbnet_set/get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGT6TwSpW22o4nEf@lunn.ch>
Date:   Thu, 1 Apr 2021 00:40:15 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Grant Grundler <grundler@...omium.org>
Cc:     Oliver Neukum <oneukum@...e.com>, Jakub Kicinski <kuba@...nel.org>,
        Roland Dreier <roland@...nel.org>,
        nic_swsd <nic_swsd@...ltek.com>, netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv4 1/4] usbnet: add _mii suffix to
 usbnet_set/get_link_ksettings

On Mon, Mar 29, 2021 at 07:16:48PM -0700, Grant Grundler wrote:
> From: Oliver Neukum <oneukum@...e.com>
> 
> The generic functions assumed devices provided an MDIO interface (accessed
> via older mii code, not phylib). This is true only for genuine ethernet.
> 
> Devices with a higher level of abstraction or based on different
> technologies do not have MDIO. To support this case, first rename
> the existing functions with _mii suffix.
> 
> v2: rebased on changed upstream
> v3: changed names to clearly say that this does NOT use phylib
> v4: moved hunks to correct patch; reworded commmit messages
> 
> Signed-off-by : Oliver Neukum <oneukum@...e.com>
> Tested-by: Roland Dreier <roland@...nel.org>
> Reviewed-by: Grant Grundler <grundler@...omium.org>
> Tested-by: Grant Grundler <grundler@...omium.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew