netdev - Re: [PATCH] xfrm/compat: Cleanup WARN()s that can be user-triggered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210331074230.GE62598@gauss3.secunet.de>
Date:   Wed, 31 Mar 2021 09:42:30 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Dmitry Safonov <dima@...sta.com>
CC:     <linux-kernel@...r.kernel.org>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        <syzbot+834ffd1afc7212eb8147@...kaller.appspotmail.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Jakub Kicinski <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH] xfrm/compat: Cleanup WARN()s that can be user-triggered

On Tue, Mar 30, 2021 at 12:25:06AM +0100, Dmitry Safonov wrote:
> Replace WARN_ONCE() that can be triggered from userspace with
> pr_warn_once(). Those still give user a hint what's the issue.
> 
> I've left WARN()s that are not possible to trigger with current
> code-base and that would mean that the code has issues:
> - relying on current compat_msg_min[type] <= xfrm_msg_min[type]
> - expected 4-byte padding size difference between
>   compat_msg_min[type] and xfrm_msg_min[type]
> - compat_policy[type].len <= xfrma_policy[type].len
> (for every type)
> 
> Reported-by: syzbot+834ffd1afc7212eb8147@...kaller.appspotmail.com
> Fixes: 5f3eea6b7e8f ("xfrm/compat: Attach xfrm dumps to 64=>32 bit translator")
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Cc: netdev@...r.kernel.org
> Cc: stable@...r.kernel.org
> Signed-off-by: Dmitry Safonov <dima@...sta.com>

Applied, thanks Dmitry!