netdev - [PATCH net] net: octeon: mgmt: fix xmit hang as busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210402102922.8495-1-ikhoronz@cisco.com>
Date:   Fri,  2 Apr 2021 10:29:22 +0000
From:   Ivan Khoronzhuk <ikhoronz@...co.com>
To:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, hch@....de,
        Ivan Khoronzhuk <ikhoronz@...co.com>
Subject: [PATCH net] net: octeon: mgmt: fix xmit hang as busy

The issue happens only at appropriate circumstances, in my case I
faced it only while running crash kernel, when basic kernel worked
fine. The code inspection has shown tx_current_fill counter overflow,
after one packet or couple packets were sent. That's because tx
cleanup tasklet dequeued bunch of not correct packets afterwards when
it should only one. As result xmit queue counter becomes more than
tx ring size and xmit always returns NETDEV_TX_BUSY. The reason is in
some trash got by dma after ringing the bell. The wmb() in correct
place solved the issue, so reason likely in removal of
mips_swiotlb_ops which had an mb() after most of the operations and
the removal of the ops had broken the tx functionality of the driver
implicitly.

The patch has been tested on Octeon II.

Fixes: a999933db9ed ("MIPS: remove mips_swiotlb_ops")
Change-Id: I947c359d9451c75a693bc4a3f2958489503fc0ab
Signed-off-by: Ivan Khoronzhuk <ikhoronz@...co.com>
---
Based on net/master

 drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
index ecffebd513be..be1c353b961c 100644
--- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
@@ -1315,6 +1315,10 @@ octeon_mgmt_xmit(struct sk_buff *skb, struct net_device *netdev)

 	spin_unlock_irqrestore(&p->tx_list.lock, flags);

+	/* Make sure there is no reorder of filling the ring and ringing
+	 * the bell
+	 */
+	wmb();
 	dma_sync_single_for_device(p->dev, p->tx_ring_handle,
 				   ring_size_to_bytes(OCTEON_MGMT_TX_RING_SIZE),
 				   DMA_BIDIRECTIONAL);
-- 
2.18.2