netdev - Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANn89i+c6k+dXwz49w7hRmuCx_4stoab5E_WmtofjNY0DRvG7g@mail.gmail.com>
Date:   Fri, 2 Apr 2021 14:53:27 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc:     Jason Wang <jasowang@...hat.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Alexander Duyck <alexanderduyck@...com>,
        Paolo Abeni <pabeni@...hat.com>,
        Greg Thelen <gthelen@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, su-lifan@...ux.alibaba.com,
        "dust.li" <dust.li@...ux.alibaba.com>,
        "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

On Fri, Apr 2, 2021 at 1:08 PM Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
>
> On Fri, 2 Apr 2021 10:52:12 +0800, Jason Wang <jasowang@...hat.com> wrote:
> >
> > So I wonder something like the following like this help. We know the
> > frag size, that means, if we know there's sufficient tailroom we can use
> > build_skb() without reserving dedicated room for skb_shared_info.
> >
> > Thanks
> >
> >
>
> Do you mean so?
>
> I have also considered this scenario, although build_skb is not always used, but
> it is also very good for the right situation.
>
> Thanks.
>

I prefer doing such experiments for net-next kernels.

Lets keep a simple patch for stable kernels.