netdev - Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202104030046.bYDrI3AB-lkp@intel.com>
Date:   Sat, 3 Apr 2021 00:29:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Loic Poulain <loic.poulain@...aro.org>, gregkh@...uxfoundation.org,
        kuba@...nel.org, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, linux-arm-msm@...r.kernel.org,
        aleksander@...ksander.es, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bjorn.andersson@...aro.org,
        manivannan.sadhasivam@...aro.org,
        Loic Poulain <loic.poulain@...aro.org>
Subject: Re: [PATCH net-next v8 2/2] net: Add Qcom WWAN control driver

Hi Loic,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bd78980be1a68d14524c51c4b4170782fada622b
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/16d753f4f524ce1aa95f45057244b1d28b50adc9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002
        git checkout 16d753f4f524ce1aa95f45057244b1d28b50adc9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wwan/mhi_wwan_ctrl.c:46:6: warning: no previous prototype for '__mhi_skb_destructor' [-Wmissing-prototypes]
      46 | void __mhi_skb_destructor(struct sk_buff *skb)
         |      ^~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/__mhi_skb_destructor +46 drivers/net/wwan/mhi_wwan_ctrl.c

    45	
  > 46	void __mhi_skb_destructor(struct sk_buff *skb)
    47	{
    48		struct mhi_wwan_dev *mhiwwan = skb_shinfo(skb)->destructor_arg;
    49	
    50		/* RX buffer has been consumed, increase the allowed budget */
    51		atomic_inc(&mhiwwan->rx_budget);
    52	
    53		if (mhi_wwan_ctrl_refill_needed(mhiwwan))
    54			schedule_work(&mhiwwan->rx_refill);
    55	}
    56	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (54282 bytes)