netdev - Re: [Patch bpf-next v8 11/16] udp: implement ->read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+F3GBo_tpbBkB0C2h12VXpzBT4dr2LekxB3NXeWnU=Tg@mail.gmail.com>
Date:   Fri, 2 Apr 2021 23:45:22 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     John Fastabend <john.fastabend@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [Patch bpf-next v8 11/16] udp: implement ->read_sock() for sockmap

On Fri, Apr 2, 2021 at 10:12 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Wed, Mar 31, 2021 at 11:01 PM John Fastabend
> <john.fastabend@...il.com> wrote:
> > This 'else if' is always true if above is false right? Would be
> > impler and clearer IMO as,
> >
> >                if (used <= 0) {
> >                         if (!copied)
> >                                 copied = used;
> >                         break;
> >                }
> >                copied += used;
> >
> > I don't see anyway for used to be great than  skb->len.
>
> Yes, slightly better. Please feel free to submit a patch by yourself,
> like always your patches are welcome.

Please submit a follow up patch as John requested
or I'm reverting your set.