netdev - Re: [PATCH net-next 02/12] ionic: add handling of larger descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <decfa346-8836-a1d4-1739-250b88e598ef@pensando.io>
Date:   Mon, 5 Apr 2021 09:17:32 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        drivers@...sando.io, Allen Hubbe <allenbh@...sando.io>
Subject: Re: [PATCH net-next 02/12] ionic: add handling of larger descriptors

On 4/4/21 3:50 PM, Richard Cochran wrote:
> On Thu, Apr 01, 2021 at 10:56:00AM -0700, Shannon Nelson wrote:
>> @@ -1722,11 +1722,15 @@ static void ionic_txrx_free(struct ionic_lif *lif)
>>   
>>   static int ionic_txrx_alloc(struct ionic_lif *lif)
>>   {
>> -	unsigned int sg_desc_sz;
>> +	unsigned int num_desc, desc_sz, comp_sz, sg_desc_sz;
>>   	unsigned int flags;
>>   	unsigned int i;
> Coding Style nit: List of ints wants alphabetically order,
> List can also fir 'flags' and 'i' with the others.
>
>> @@ -2246,9 +2258,9 @@ static void ionic_swap_queues(struct ionic_qcq *a, struct ionic_qcq *b)
>>   int ionic_reconfigure_queues(struct ionic_lif *lif,
>>   			     struct ionic_queue_params *qparam)
>>   {
>> +	unsigned int num_desc, desc_sz, comp_sz, sg_desc_sz;
>>   	struct ionic_qcq **tx_qcqs = NULL;
>>   	struct ionic_qcq **rx_qcqs = NULL;
>> -	unsigned int sg_desc_sz;
>>   	unsigned int flags;
> Ditto.
>
> Thanks,
> Richard

I can tweak this is a followup patch.  Thanks for your review time.
sln