netdev - Re: [PATCH net-next v3 09/18] include: bitmap: add macro for bitmap initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGzw9keA5yZc09bZ@lunn.ch>
Date:   Wed, 7 Apr 2021 01:38:30 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>, kuba@...nel.org
Subject: Re: [PATCH net-next v3 09/18] include: bitmap: add macro for bitmap
 initialization

On Wed, Apr 07, 2021 at 12:10:58AM +0200, Marek Behún wrote:
> Use the new variadic-macro.h library to implement macro
> INITIALIZE_BITMAP(nbits, ...), which can be used for compile time bitmap
> initialization in the form
>   static DECLARE_BITMAP(bm, 100) = INITIALIZE_BITMAP(100, 7, 9, 66, 98);
> 
> The macro uses the BUILD_BUG_ON_ZERO mechanism to ensure a compile-time
> error if an argument is out of range.
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>
> ---
>  include/linux/bitmap.h | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 70a932470b2d..a9e74d3420bf 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -8,6 +8,7 @@
>  #include <linux/bitops.h>
>  #include <linux/string.h>
>  #include <linux/kernel.h>
> +#include <linux/variadic-macro.h>
>  
>  /*
>   * bitmaps provide bit arrays that consume one or more unsigned
> @@ -114,6 +115,29 @@
>   * contain all bit positions from 0 to 'bits' - 1.
>   */
>  
> +/**
> + * DOC: initialize bitmap
> + * The INITIALIZE_BITMAP(bits, args...) macro expands to a designated
> + * initializer for bitmap of length 'bits', setting each bit specified
> + * in 'args...'.
> + */

Doesn't the /** mean this is kernel doc? The rest does not seem to
follow kdoc. Does this compile cleanly with W=1?

       Andrew