netdev - Re: [PATCH net v3] net: hsr: Reset MAC header for Tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLJA0F5WF1AK9QGHr_XeEfKvu4ueko0n1GH_viJkCax0A@mail.gmail.com>
Date:   Tue, 6 Apr 2021 10:42:09 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Murali Karicheri <m-karicheri2@...com>,
        Taehee Yoo <ap420073@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        George McCollister <george.mccollister@...il.com>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Wang Hai <wanghai38@...wei.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net v3] net: hsr: Reset MAC header for Tx path

On Tue, Apr 6, 2021 at 9:35 AM Kurt Kanzenbach <kurt@...utronix.de> wrote:
>
> Reset MAC header in HSR Tx path. This is needed, because direct packet
> transmission, e.g. by specifying PACKET_QDISC_BYPASS does not reset the MAC
> header.
>
> This has been observed using the following setup:
>
> |$ ip link add name hsr0 type hsr slave1 lan0 slave2 lan1 supervision 45 version 1
> |$ ifconfig hsr0 up
> |$ ./test hsr0
>
> The test binary is using mmap'ed sockets and is specifying the
> PACKET_QDISC_BYPASS socket option.
>
> This patch resolves the following warning on a non-patched kernel:
>
> |[  112.725394] ------------[ cut here ]------------
> |[  112.731418] WARNING: CPU: 1 PID: 257 at net/hsr/hsr_forward.c:560 hsr_forward_skb+0x484/0x568
> |[  112.739962] net/hsr/hsr_forward.c:560: Malformed frame (port_src hsr0)
>
> The warning can be safely removed, because the other call sites of
> hsr_forward_skb() make sure that the skb is prepared correctly.
>
> Fixes: d346a3fae3ff ("packet: introduce PACKET_QDISC_BYPASS socket option")
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>