netdev - Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <211FD3E3-54AF-41A4-91BF-EEB01680A1CC@oracle.com>
Date:   Wed, 7 Apr 2021 18:26:41 +0000
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Aditya Pakki <pakki001@....edu>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/rds: Avoid potential use after free in
 rds_send_remove_from_sock


> On Apr 6, 2021, at 5:09 PM, Aditya Pakki <pakki001@....edu> wrote:
> 
> In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource
> is freed and later under spinlock, causing potential use-after-free.
> Set the free pointer to NULL to avoid undefined behavior.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
> net/rds/message.c | 1 +
> net/rds/send.c    | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)

Looks fine by me. Thanks.

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>