netdev - Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 20:49:33 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>, vivien.didelot@...il.com,
        olteanv@...il.com, netdev@...r.kernel.org, davem@...emloft.net,
        kuba@...nel.org, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all
 remaining GSWIP_MII_CFG bits

Hello,

On Wed, Apr 7, 2021 at 6:47 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>
>
>
> On 4/6/2021 5:32 PM, Andrew Lunn wrote:
> >>      case PHY_INTERFACE_MODE_RGMII:
> >>      case PHY_INTERFACE_MODE_RGMII_ID:
> >>      case PHY_INTERFACE_MODE_RGMII_RXID:
> >>      case PHY_INTERFACE_MODE_RGMII_TXID:
> >>              miicfg |= GSWIP_MII_CFG_MODE_RGMII;
> >> +
> >> +            if (phylink_autoneg_inband(mode))
> >> +                    miicfg |= GSWIP_MII_CFG_RGMII_IBS;
> >
> > Is there any other MAC driver doing this? Are there any boards
> > actually enabling it? Since it is so odd, if there is nothing using
> > it, i would be tempted to leave this out.
>
> Some PHYs (Broadcom namely) support suppressing the RGMII in-band
> signaling towards the MAC, so if the MAC relies on that signaling to
> configure itself based on what the PHY reports this may not work.
point taken. in v2 we'll not set GSWIP_MII_CFG_RGMII_IBS unless
there's someone who can actually test this.
so far I don't know any hardware with Lantiq SoC that uses it


Best regards,
Martin