netdev - Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210408010640.GH2900@Leo-laptop-t470s>
Date:   Thu, 8 Apr 2021 09:06:40 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     netdev@...r.kernel.org, "Jason A . Donenfeld" <Jason@...c4.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Ondrej Mosnacek <omosnace@...hat.com>,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

On Wed, Apr 07, 2021 at 02:12:27PM -0700, Eric Biggers wrote:
> On Wed, Apr 07, 2021 at 07:39:20PM +0800, Hangbin Liu wrote:
> > As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not
> > FIPS certified, the WireGuard module should be disabled in FIPS mode.
> > 
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> 
> I think you mean "FIPS allowed", not "FIPS certified"?  Even if it used FIPS
> allowed algorithms like AES, the Linux kernel doesn't come with any sort of FIPS
> certification out of the box.

Yes, you are right.
> 
> Also, couldn't you just consider WireGuard to be outside your FIPS module
> boundary, which would remove it from the scope of the certification?
> 
> And how do you handle all the other places in the kernel that use ChaCha20 and
> SipHash?  For example, drivers/char/random.c?

Good question, I will check it and reply to you later.

Thanks
Hangbin