netdev - Re: [PATCH v2] ipv6: report errors for iftoken via netlink extack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 08:20:50 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Cc:     Hongren Zheng <li@...ithal.me>
Subject: Re: [PATCH v2] ipv6: report errors for iftoken via netlink extack

On 4/7/21 9:59 AM, Stephen Hemminger wrote:
> From: Stephen Hemminger <stephen@...workplumber.org>
> 
> Setting iftoken can fail for several different reasons but there
> and there was no report to user as to the cause. Add netlink
> extended errors to the processing of the request.
> 
> This requires adding additional argument through rtnl_af_ops
> set_link_af callback.
> 
> Reported-by: Hongren Zheng <li@...ithal.me>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> ---
> v2 - fix typo that broke build
> 
>  include/net/rtnetlink.h |  4 ++--
>  net/core/rtnetlink.c    |  2 +-
>  net/ipv4/devinet.c      |  3 ++-
>  net/ipv6/addrconf.c     | 32 ++++++++++++++++++++++++++------
>  4 files changed, 31 insertions(+), 10 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>