netdev - RE: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages PHY PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 05:42:35 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Fugang Duan <fugang.duan@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver
 manages PHY PM


Hi Heiner,

Why not target this patch set to net repo as a bug fixes? Others may also suffer from this.

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Heiner Kallweit <hkallweit1@...il.com>
> Sent: 2021年4月7日 23:51
> To: Andrew Lunn <andrew@...n.ch>; Russell King - ARM Linux
> <linux@...linux.org.uk>; Jakub Kicinski <kuba@...nel.org>; David Miller
> <davem@...emloft.net>; Fugang Duan <fugang.duan@....com>
> Cc: netdev@...r.kernel.org; Joakim Zhang <qiangqing.zhang@....com>
> Subject: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver
> manages PHY PM
> 
> Resume callback of the PHY driver is called after the one for the MAC driver.
> The PHY driver resume callback calls phy_init_hw(), and this is potentially
> problematic if the MAC driver calls phy_start() in its resume callback. One issue
> was reported with the fec driver and a KSZ8081 PHY which seems to become
> unstable if a soft reset is triggered during aneg.
> 
> The new flag allows MAC drivers to indicate that they take care of
> suspending/resuming the PHY. Then the MAC PM callbacks can handle any
> dependency between MAC and PHY PM.
> 
> Heiner Kallweit (3):
>   net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM
>   net: fec: use mac-managed PHY PM
>   r8169: use mac-managed PHY PM
> 
>  drivers/net/ethernet/freescale/fec_main.c | 3 +++
> drivers/net/ethernet/realtek/r8169_main.c | 3 +++
>  drivers/net/phy/phy_device.c              | 6 ++++++
>  include/linux/phy.h                       | 2 ++
>  4 files changed, 14 insertions(+)
> 
> --
> 2.31.1