netdev - Re: [PATCH net v2 0/3] Action initalization fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUmaQ2w7pd7xn4deHu6sYb8wRO62mN_97nN6Kwte7t3LQ@mail.gmail.com>
Date:   Thu, 8 Apr 2021 15:02:09 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        David Miller <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Jakub Kicinski <kuba@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH net v2 0/3] Action initalization fixes

On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov <vladbu@...dia.com> wrote:
>
> This series fixes reference counting of action instances and modules in
> several parts of action init code. The first patch reverts previous fix
> that didn't properly account for rollback from a failure in the middle of
> the loop in tcf_action_init() which is properly fixed by the following
> patch.

I still hate the init_res[] array, but I have no easy and better way to fix
it either, so:

Acked-by: Cong Wang <cong.wang@...edance.com>

For the long term, we probably want to split the action ->init() into
two: ->init() and ->change(), like TC filters, which hopefully could
ease the complexity of tcf_action_init_1().

Thanks.