netdev - Re: [PATCH] ibmvnic: Continue with reset if set link down failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Apr 2021 23:03:58 -0700
From:   Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
To:     Dany Madden <drt@...ux.ibm.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, ljp@...ux.ibm.com,
        ricklind@...ux.ibm.com
Subject: Re: [PATCH] ibmvnic: Continue with reset if set link down failed

Dany Madden [drt@...ux.ibm.com] wrote:
> When an adapter is going thru a reset, it maybe in an unstable state that
> makes a request to set link down fail. In such a case, the adapter needs
> to continue on with reset to bring itself back to a stable state.
> 
> Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> Signed-off-by: Dany Madden <drt@...ux.ibm.com>

Given that the likely reason for set_link_state() failing is that the
CRQ is inactive and that we will attempt to free the CRQ and re-register
it in ibmvnic_reset_crq() further down, I think its okay to ignore the
error here.

Reviewed-by: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>