netdev - Re: [PATCH net v2] net: fix hangup on napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLiZZeomS2yBh7OXmu_zrxfZt8soebD+XUcJq0f6wH=vg@mail.gmail.com>
Date:   Fri, 9 Apr 2021 17:52:33 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Paolo Abeni <pabeni@...hat.com>, netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Wei Wang <weiwan@...gle.com>
Subject: Re: [PATCH net v2] net: fix hangup on napi_disable for threaded napi

On Fri, Apr 9, 2021 at 5:35 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>

>
> Unrelated to the actual issue:
> I wonder why -1 is returned, that's unusual in kernel. The return value
> is used as bool, so why not return a bool?

This is a leftover of a prior implementation that returned 3 values.

No bug here really, this is a matter of taste I suppose.