netdev - Re: [PATCH RFC iproute2-next] iplink: allow to change iplink value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210411100411.6d16e51d@hermes.local>
Date:   Sun, 11 Apr 2021 10:04:11 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     netdev@...r.kernel.org,
        Marek Behún <marek.behun@....cz>,
        David Ahern <dsahern@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        Eric Dumazet <edumazet@...gle.com>,
        Wei Wang <weiwan@...gle.com>,
        Cong Wang <cong.wang@...edance.com>,
        Taehee Yoo <ap420073@...il.com>,
        Björn Töpel <bjorn@...nel.org>,
        Di Zhu <zhudi21@...wei.com>,
        Weilong Chen <chenweilong@...wei.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Colin Ian King <colin.king@...onical.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        Francis Laniel <laniel_francis@...vacyrequired.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC iproute2-next] iplink: allow to change iplink value

On Sat, 10 Apr 2021 15:34:50 +0200
Ansuel Smith <ansuelsmth@...il.com> wrote:

> Allow to change the interface to which a given interface is linked to.
> This is useful in the case of multi-CPU port DSA, for changing the CPU
> port of a given user port.
> 
> Signed-off-by: Marek Behún <marek.behun@....cz>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>

This may work for DSA but it won't work for all the device types vlan/macsec/... that
now use the link attribute.  It looks like the change link handling for those
device types just ignores the link attribute (maybe ok). But before supporting this
as an API, it would be better if all the other drivers that use IFLA_LINK
had error checks in their change link handling.

Please add error checks in kernel first.