netdev - Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Apr 2021 20:23:06 +0900
From:   Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     linux-can <linux-can@...r.kernel.org>,
        Jimmy Assarsson <extja@...ser.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Arunachalam Santhanam <arunachalam.santhanam@...bosch.com>,
        Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

Hi Marc,

On Mon. 12 Apr 2021 at 18:20, Marc Kleine-Budde <mkl@...gutronix.de> wrote:
> On 10.04.2021 18:59:45, Vincent Mailhol wrote:
> > Here comes the 15th iteration of the patch. This new version addresses
> > the comments received from Marc (thanks again for the review!) and
> > simplify the device probing by using .driver_info.
>
> diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
> index 35ba8af89b2e..7222b3b6ca46 100644
> --- a/drivers/net/can/usb/etas_es58x/es58x_core.c
> +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
> @@ -1096,7 +1096,7 @@ static void es58x_increment_rx_errors(struct es58x_device *es58x_dev)
>   *     be aligned.
>   *
>   * Sends the URB command to the device specific function. Manages the
> - * errors throwed back by those functions.
> + * errors thrown back by those functions.
>   */
>  static void es58x_handle_urb_cmd(struct es58x_device *es58x_dev,
>                                  const union es58x_urb_cmd *urb_cmd)
>
> I have applied to linux-can-next/testing with the above spell fix.
> Thanks for the steady work on this and all the other features.

Thanks to you too! This, together with the other features is my
very first open source contribution. I learned a lot from you,
Oliver and the others from the mailing list. It was a nice
experience.

That said, you will eventually hear from me again on the TDC
netlink interface (and probably other topics as well).


Yours sincerely,
Vincent