netdev - Re: [PATCH net-next] icmp: pass RFC 8335 reply messages to ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f969d15083f8f7b7ba9ef001505ad2e16b0c2fdd.camel@gmail.com>
Date:   Mon, 12 Apr 2021 14:40:48 -0500
From:   Andreas Roeseler <andreas.a.roeseler@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] icmp: pass RFC 8335 reply messages to ping_rcv

On Mon, 2021-04-12 at 15:28 -0400, Willem de Bruijn wrote:
> On Mon, Apr 12, 2021 at 3:09 PM Andreas Roeseler
> <andreas.a.roeseler@...il.com> wrote:
> > 
> > The current icmp_rcv function drops all unknown ICMP types,
> > including
> > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply
> > messages, we have
> > to pass these packets to the ping_rcv function, which does not do
> > any
> > other filtering and passes the packet to the designated socket.
> > 
> > Pass incoming RFC 8335 ICMP Extended Echo Reply packets to the
> > ping_rcv
> > handler instead of discarding the packet.
> > 
> > Signed-off-by: Andreas Roeseler <andreas.a.roeseler@...il.com>
> > ---
> >  net/ipv4/icmp.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> > index 76990e13a2f9..8bd988fbcb31 100644
> > --- a/net/ipv4/icmp.c
> > +++ b/net/ipv4/icmp.c
> > @@ -1196,6 +1196,11 @@ int icmp_rcv(struct sk_buff *skb)
> >                 goto success_check;
> >         }
> > 
> > +       if (icmph->type == ICMP_EXT_ECHOREPLY) {
> > +               success = ping_rcv(skb);
> > +               goto success_check;
> > +       }
> > +
> 
> Do you need the same for ICMPV6_EXT_ECHO_REPLY ?

Yes, but this should be handled in icmpv6_rcv in net/ipv6/icmp.c and
we're thinking of including all icmpv6 support for RFC 8335 (replying
and parsing replies) in a separate patch.