netdev - Re: Broken imx6 to QCA8334 connection since PHYLIB to PHYLINK conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1927419-1392-7599-c74d-5305b536e018@ysoft.com>
Date:   Tue, 13 Apr 2021 15:26:30 +0200
From:   Michal Vokáč <michal.vokac@...ft.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jonathan McDowell <noodles@...th.li>,
        Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: Broken imx6 to QCA8334 connection since PHYLIB to PHYLINK
 conversion

On 13. 04. 21 14:44, Andrew Lunn wrote:
> On Tue, Apr 13, 2021 at 09:09:37AM +0200, Michal Vokáč wrote:
>> On 12. 04. 21 16:14, Andrew Lunn wrote:
>> The FEC does not have PHY and is connected to the switch at RGMII level.
>> Adding the fixed-link { speed = <1000>; full-duplex; }; subnode to FEC
>> does not help.
> 
> If the FEC does not have a PHY, it should not have a
> phy-handle. Instead, you need a fixed-link.
> 
> What is currently happening is that both the switch and the FEC are
> trying to connect to the same PHY. Probably the switch does its
> connection first and succeeds. When the FEC tries to connect, the PHY
> is in use, so an error is returned.
> 
> By providing a fixed-link, instead of a phy-handle, a simulated PHY is
> generated, which the FEC can connect to.

That was it, thanks a lot Andrew! I will send a patch ASAP.

Michal