netdev - Re: [PATCH] wireless: marvell: mwl8k: Fix a double Free in mwl8k_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56a96726.42ca6.178cc0b3e40.Coremail.lyl2019@mail.ustc.edu.cn>
Date:   Wed, 14 Apr 2021 00:23:12 +0800 (GMT+08:00)
From:   lyl2019@...l.ustc.edu.cn
To:     "Lv Yunlong" <lyl2019@...l.ustc.edu.cn>
Cc:     buytenh@...tstofly.org, kvalo@...eaurora.org, davem@...emloft.net,
        kuba@...nel.org, gustavoars@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wireless: marvell: mwl8k: Fix a double Free in
 mwl8k_probe_hw


Dear maintainers,
    
     I'm sorry to disturb you, but this patch has not been reviewed for more than a week.
     Could you please help to review this patch? It will not take you a lot time.

Sincerely.

> -----原始邮件-----
> 发件人: "Lv Yunlong" <lyl2019@...l.ustc.edu.cn>
> 发送时间: 2021-04-03 02:26:27 (星期六)
> 收件人: buytenh@...tstofly.org, kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org, gustavoars@...nel.org
> 抄送: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "Lv Yunlong" <lyl2019@...l.ustc.edu.cn>
> 主题: [PATCH] wireless: marvell: mwl8k: Fix a double Free in mwl8k_probe_hw
> 
> In mwl8k_probe_hw, hw->priv->txq is freed at the first time by
> dma_free_coherent() in the call chain:
> if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i).
> 
> Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed
> at the second time by mwl8k_txq_deinit(hw, i)->dma_free_coherent().
> 
> My patch set txq->txd to NULL after the first free to avoid the
> double free.
> 
> Fixes: a66098daacee2 ("mwl8k: Marvell TOPDOG wireless driver")
> Signed-off-by: Lv Yunlong <lyl2019@...l.ustc.edu.cn>
> ---
>  drivers/net/wireless/marvell/mwl8k.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
> index c9f8c056aa51..84b32a5f01ee 100644
> --- a/drivers/net/wireless/marvell/mwl8k.c
> +++ b/drivers/net/wireless/marvell/mwl8k.c
> @@ -1473,6 +1473,7 @@ static int mwl8k_txq_init(struct ieee80211_hw *hw, int index)
>  	if (txq->skb == NULL) {
>  		dma_free_coherent(&priv->pdev->dev, size, txq->txd,
>  				  txq->txd_dma);
> +		txq->txd = NULL;
>  		return -ENOMEM;
>  	}
>  
> -- 
> 2.25.1
>