netdev - Re: [PATCH] lib: remove "expecting prototype" kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02166180-2ffe-ed4b-91dc-cde198004fcc@infradead.org>
Date:   Tue, 13 Apr 2021 11:31:25 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Philipp Reisner <philipp.reisner@...bit.com>,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        drbd-dev@...n.linbit.com, Jiri Pirko <jiri@...dia.com>,
        netdev@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH] lib: remove "expecting prototype" kernel-doc warnings

On 4/13/21 11:18 AM, Andrew Morton wrote:
> On Sun, 11 Apr 2021 15:17:56 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> Fix various kernel-doc warnings in lib/ due to missing or
>> erroneous function names.
>> Add kernel-doc for some function parameters that was missing.
>> Use kernel-doc "Return:" notation in earlycpio.c.
>>
>> Quietens the following warnings:
>>
>> ../lib/earlycpio.c:61: warning: expecting prototype for cpio_data find_cpio_data(). Prototype was for find_cpio_data() instead
>>
>> ../lib/lru_cache.c:640: warning: expecting prototype for lc_dump(). Prototype was for lc_seq_dump_details() instead
>> lru_cache.c:90: warning: Function parameter or member 'cache' not described in 'lc_create'
> 
> I'm still seeing this.
> 

Weird. I can't reproduce it.

>> lru_cache.c:90: warning: Function parameter or member 'cache' not described in 'lc_create'
> 
> But it looks OK:
> 

Yes.

> /**
>  * lc_create - prepares to track objects in an active set
>  * @name: descriptive name only used in lc_seq_printf_stats and lc_seq_dump_details
>  * @cache: cache root pointer
>  * @max_pending_changes: maximum changes to accumulate until a transaction is required
>  * @e_count: number of elements allowed to be active simultaneously
>  * @e_size: size of the tracked objects
>  * @e_off: offset to the &struct lc_element member in a tracked object
>  *
>  * Returns a pointer to a newly initialized struct lru_cache on success,
>  * or NULL on (allocation) failure.
>  */
> struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
> 		unsigned max_pending_changes,
> 		unsigned e_count, size_t e_size, size_t e_off)
> {
> 

I'll keep looking...

-- 
~Randy