netdev - Re: [PATCHv4 bpf-next 4/5] selftests/bpf: Add re-attach test to lsm test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YHbJ54+KIY6kEHyd@krava>
Date:   Wed, 14 Apr 2021 12:54:31 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCHv4 bpf-next 4/5] selftests/bpf: Add re-attach test to lsm
 test

On Tue, Apr 13, 2021 at 02:57:26PM -0700, Andrii Nakryiko wrote:
> On Mon, Apr 12, 2021 at 9:31 AM Jiri Olsa <jolsa@...nel.org> wrote:
> >
> > Adding the test to re-attach (detach/attach again) lsm programs,
> > plus check that already linked program can't be attached again.
> >
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  .../selftests/bpf/prog_tests/test_lsm.c       | 48 +++++++++++++++----
> >  1 file changed, 38 insertions(+), 10 deletions(-)
> >
> 
> Surprised you didn't switch this one to ASSERT, but ok, we can do it
> some other time ;)

yep, I commented on that in the previous version ;-)

  - used ASSERT* macros apart from lsm test, which is using
    CHECKs all over the place [Andrii]

I think it should go to separate patch, so it won't shade
the actual change

jirka

> 
> Acked-by: Andrii Nakryiko <andrii@...nel.org>
> 
> 
> > diff --git a/tools/testing/selftests/bpf/prog_tests/test_lsm.c b/tools/testing/selftests/bpf/prog_tests/test_lsm.c
> > index 2755e4f81499..d492e76e01cf 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/test_lsm.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/test_lsm.c
> > @@ -18,6 +18,8 @@ char *CMD_ARGS[] = {"true", NULL};
> >  #define GET_PAGE_ADDR(ADDR, PAGE_SIZE)                                 \
> >         (char *)(((unsigned long) (ADDR + PAGE_SIZE)) & ~(PAGE_SIZE-1))
> >
> 
> [...]
>