netdev - Re: [net-next V2 01/16] net/mlx5: E-Switch, let user to enable disable metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210414113501.20cea8ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 14 Apr 2021 11:35:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Parav Pandit <parav@...dia.com>, Roi Dayan <roid@...dia.com>,
        Vu Pham <vuhuong@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net-next V2 01/16] net/mlx5: E-Switch, let user to enable
 disable metadata

On Wed, 14 Apr 2021 11:05:50 -0700 Saeed Mahameed wrote:
> From: Parav Pandit <parav@...dia.com>
> 
> Currently each packet inserted in eswitch is tagged with a internal
> metadata to indicate source vport. Metadata tagging is not always
> needed. Metadata insertion is needed for multi-port RoCE, failover
> between representors and stacked devices. In many other cases,
> metadata enablement is not needed.
> 
> Metadata insertion slows down the packet processing rate of the E-switch
> when it is in switchdev mode.
> 
> Below table show performance gain with metadata disabled for VXLAN
> offload rules in both SMFS and DMFS steering mode on ConnectX-5 device.
> 
> ----------------------------------------------
> | steering | metadata | pkt size | rx pps    |
> | mode     |          |          | (million) |
> ----------------------------------------------
> | smfs     | disabled | 128Bytes | 42        |
> ----------------------------------------------
> | smfs     | enabled  | 128Bytes | 36        |
> ----------------------------------------------
> | dmfs     | disabled | 128Bytes | 42        |
> ----------------------------------------------
> | dmfs     | enabled  | 128Bytes | 36        |
> ----------------------------------------------
> 
> Hence, allow user to disable metadata using driver specific devlink
> parameter. Metadata setting of the eswitch is applicable only for the
> switchdev mode.
> 
> Example to show and disable metadata before changing eswitch mode:
> $ devlink dev param show pci/0000:06:00.0 name esw_port_metadata
> pci/0000:06:00.0:
>   name esw_port_metadata type driver-specific
>     values:
>       cmode runtime value true
> 
> $ devlink dev param set pci/0000:06:00.0 \
> 	  name esw_port_metadata value false cmode runtime
> 
> $ devlink dev eswitch set pci/0000:06:00.0 mode switchdev
> 
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Roi Dayan <roid@...dia.com>
> Reviewed-by: Vu Pham <vuhuong@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

Acked-by: Jakub Kicinski <kuba@...nel.org>