netdev - Re: [PATCH net-next 2/7] net: korina: Use devres functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YHdEutTGEOz9dhVr@lunn.ch>
Date:   Wed, 14 Apr 2021 21:38:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/7] net: korina: Use devres functions

> +	if (!p) {
>  		printk(KERN_ERR DRV_NAME ": cannot remap registers\n");
> -		rc = -ENXIO;
> -		goto probe_err_out;
> +		return -ENOMEM;
>  	}

Hi Thomas

Another possible cleanup would be replacing printk(KERN_ERR with
dev_err(), or netdev_err() etc.

	   Andrew