netdev - Re: [PATCH net-next] skbuff: revert "skbuff: remove some unnecessary operation in skb_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 21:10:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, linyunsheng@...wei.com,
        dseok.yi@...sung.com, willemb@...gle.com
Subject: Re: [PATCH net-next] skbuff: revert "skbuff: remove some unnecessary
 operation in skb_segment_list()"

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 14 Apr 2021 12:48:48 +0200 you wrote:
> the commit 1ddc3229ad3c ("skbuff: remove some unnecessary operation
> in skb_segment_list()") introduces an issue very similar to the
> one already fixed by commit 53475c5dd856 ("net: fix use-after-free when
> UDP GRO with shared fraglist").
> 
> If the GSO skb goes though skb_clone() and pskb_expand_head() before
> entering skb_segment_list(), the latter  will unshare the frag_list
> skbs and will release the old list. With the reverted commit in place,
> when skb_segment_list() completes, skb->next points to the just
> released list, and later on the kernel will hit UaF.
> 
> [...]

Here is the summary with links:
  - [net-next] skbuff: revert "skbuff: remove some unnecessary operation in skb_segment_list()"
    https://git.kernel.org/netdev/net-next/c/17c3df7078e3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html