netdev - Re: [PATCH] net: Make tcp_allowed_congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210414160918.70c0d7ab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 14 Apr 2021 16:09:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathon Reinhart <jonathon.reinhart@...il.com>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in
 non-init netns

On Wed, 14 Apr 2021 17:31:55 -0400 Jonathon Reinhart wrote:
> On Tue, Apr 13, 2021 at 2:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Tue, 13 Apr 2021 03:08:48 -0400 Jonathon Reinhart wrote:  
> > > Fixes: 9cb8e048e5d9: ("net/ipv4/sysctl: show tcp_{allowed, available}_congestion_control in non-initial netns")  
> >
> > nit: no semicolon after the hash  
> 
> Oops. scripts/checkpatch.pl didn't catch this, but it looks like patchwork did.
> 
> You indicated "nit": Shall I resubmit, or can something trivial like
> this be fixed up when committed? I'm fine either way, I just need to
> know what's expected.

I was just pointing it out, I wasn't 100% sure if it's important enough
for DaveM to request a repost.

> Also, this patch shows up in patchwork as "Not Applicable". I didn't
> see any notification about that state change, nor do I really know
> what that means. Was that due to this nit, or something else?
> 
> Thanks for guiding me through this.

I think best way forward is to repost with the nit addressed.