netdev - Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YHaC74uSAJg/ZO7x@kroah.com>
Date:   Wed, 14 Apr 2021 07:51:43 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nico Pache <npache@...hat.com>
Cc:     linux-kernel@...r.kernel.org, brendanhiggins@...gle.com,
        linux-ext4@...r.kernel.org, netdev@...r.kernel.org,
        rafael@...nel.org, linux-m68k@...ts.linux-m68k.org,
        geert@...ux-m68k.org
Subject: Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the
 standard

On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote:
> There are few instances of KUNIT tests that are not properly defined.
> This commit focuses on correcting these issues to match the standard
> defined in the Documentation.
> 
>     Issues Fixed:
>  - Tests should default to KUNIT_ALL_TESTS
>  - Tests configs tristate should have `if !KUNIT_ALL_TESTS`
>  - Tests should end in KUNIT_TEST, some fixes have been applied to
>     correct issues were KUNIT_TESTS is used or KUNIT is not mentioned.

You are changing lots of different things all in one patch, please break
this up into "one config option change per patch" to make it easier to
review and get merged through the proper subsystem.

thanks,

greg k-h