netdev - Re: [PATCH v3 net-next] net: multipath routing: configurable seed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 10:45:47 +0300
From:   Pavel Balaev <mail@...d.so>
To:     netdev@...r.kernel.org
Cc:     christophe.jaillet@...adoo.fr, kuba@...nel.org,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org
Subject: Re: [PATCH v3 net-next] net: multipath routing: configurable seed

On Tue, Apr 13, 2021 at 04:15:21PM -0700, David Miller wrote:
> From: Balaev Pavel <balaevpa@...otecs.ru>
> Date: Tue, 13 Apr 2021 14:55:04 +0300
> 
> > @@ -222,6 +230,9 @@ struct netns_ipv4 {
> >  #ifdef CONFIG_IP_ROUTE_MULTIPATH
> >  	u8 sysctl_fib_multipath_use_neigh;
> >  	u8 sysctl_fib_multipath_hash_policy;
> > +	int sysctl_fib_multipath_hash_seed;
> > +	struct multipath_seed_ctx __rcu *fib_multipath_hash_seed_ctx;
> > +	spinlock_t fib_multipath_hash_seed_ctx_lock;
> 
> Maybe use the rtnl mutex instead of this custom spinlock?
> 
> Thanks.
Thanks for advise, I will use it in next patch version.