netdev - Re: [PATCH net] r8169: don't advertise pause in jumbo mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 10:18:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Roman Mamedov <rm+bko@...anrm.net>
Subject: Re: [PATCH net] r8169: don't advertise pause in jumbo mode

On Wed, Apr 14, 2021 at 09:56:30AM +0200, Heiner Kallweit wrote:
> On 14.04.2021 09:49, Greg KH wrote:
> > On Wed, Apr 14, 2021 at 09:40:51AM +0200, Heiner Kallweit wrote:
> >> It has been reported [0] that using pause frames in jumbo mode impacts
> >> performance. There's no available chip documentation, but vendor
> >> drivers r8168 and r8125 don't advertise pause in jumbo mode. So let's
> >> do the same, according to Roman it fixes the issue.
> >>
> >> [0] https://bugzilla.kernel.org/show_bug.cgi?id=212617
> >>
> >> Fixes: 9cf9b84cc701 ("r8169: make use of phy_set_asym_pause")
> >> Reported-by: Roman Mamedov <rm+bko@...anrm.net>
> >> Tested-by: Roman Mamedov <rm+bko@...anrm.net>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> >> ---
> >> This patch doesn't apply cleanly on some kernel versions, but the needed
> >> changes are trivial.
> >> ---
> >>  drivers/net/ethernet/realtek/r8169_main.c | 9 +++++++--
> >>  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > 
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read:
> >     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> > 
> > </formletter>
> > 
> Until recently the procedure in netdev has been to annotate the patch as
> "net" and not cc stable. IIRC there is an experiment to cc stable.
> If this isn't applicable any longer and the old process still applies,
> then please ignore the cc'ed stable.

You need to put the "Cc: stable..." in the signed-off-by area, as the
documentation link above states.

thanks,

greg k-h