netdev - Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e26fbcc8-ba3e-573a-523d-9c5d5f84bc46@tessares.net>
Date:   Wed, 14 Apr 2021 11:25:03 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Nico Pache <npache@...hat.com>, linux-kernel@...r.kernel.org
Cc:     brendanhiggins@...gle.com, gregkh@...uxfoundation.org,
        linux-ext4@...r.kernel.org, netdev@...r.kernel.org,
        rafael@...nel.org, linux-m68k@...ts.linux-m68k.org,
        geert@...ux-m68k.org, tytso@....edu,
        mathew.j.martineau@...ux.intel.com, davem@...emloft.net,
        broonie@...nel.org, davidgow@...gle.com, skhan@...uxfoundation.org,
        mptcp@...ts.linux.dev
Subject: Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi Nico,

On 14/04/2021 10:58, Nico Pache wrote:
> Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the
> KUNIT *_KUNIT_TEST config name format.

For MPTCP, we have multiple KUnit tests: crypto and token. That's why we 
wrote TESTS with a S.

I'm fine without S if we need to stick with KUnit' standard. But maybe 
the standard wants us to split the two tests and create 
MPTCP_TOKEN_KUNIT_TEST and MPTCP_TOKEN_KUNIT_TEST config?

In this case, we could eventually keep MPTCP_KUNIT_TESTS which will in 
charge of selecting the two new ones.

Up to the KUnit maintainers to decide ;-)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net