netdev - Re: [PATCH net-next] net: ethernet: mediatek: fix typo in offload code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86DA3F5B-32B2-446B-B83D-AFDC5EE6BF53@public-files.de>
Date:   Thu, 15 Apr 2021 12:05:26 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     linux-mediatek@...ts.infradead.org,
        DENG Qingfang <dqfext@...il.com>, Felix Fietkau <nbd@....name>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
CC:     Alex Ryabchenko <d3adme4t@...il.com>
Subject: Re: [PATCH net-next] net: ethernet: mediatek: fix typo in offload code

Am 15. April 2021 11:40:05 MESZ schrieb DENG Qingfang <dqfext@...il.com>:
>.key_offset was assigned to .head_offset instead. Fix the typo.
>
>Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading
>support")
>Signed-off-by: DENG Qingfang <dqfext@...il.com>

Thanks for posting the fix,but imho commit-message is not good.

Issue were traffic problems after a while with increased ping times if flow offload is active.

It turns out that key_offset with cookie is needed in rhashtable_params and head_offset was defined twice.
regards Frank