netdev - Re: [PATCH net] igb: Fix XDP with PTP enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874kg7hhej.fsf@kurt>
Date:   Thu, 15 Apr 2021 14:16:36 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Jesper Dangaard Brouer <jbrouer@...hat.com>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Sven Auhagen <sven.auhagen@...eatech.de>,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net] igb: Fix XDP with PTP enabled

On Thu Apr 15 2021, Jesper Dangaard Brouer wrote:
> On Thu, 15 Apr 2021 11:21:45 +0200
> Kurt Kanzenbach <kurt@...utronix.de> wrote:
>
>> When using native XDP with the igb driver, the XDP frame data doesn't point to
>> the beginning of the packet. It's off by 16 bytes. Everything works as expected
>> with XDP skb mode.
>> 
>> Actually these 16 bytes are used to store the packet timestamps. Therefore, pull
>> the timestamp before executing any XDP operations and adjust all other code
>> accordingly. The igc driver does it like that as well.
>> 
>> Tested with Intel i210 card and AF_XDP sockets.
>
> Doesn't the i210 card use the igc driver?
> This change is for igb driver.

Nope. igb is for i210 and igc is for the newer Intel i225 NICs.

|01:00.0 Ethernet controller: Intel Corporation I210 Gigabit Network Connection (rev 03)
|[...]
|        Kernel driver in use: igb
|        Kernel modules: igb

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)