netdev - Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3949501-8f7d-57c4-b3fe-bcc3b24c09d8@isovalent.com>
Date:   Thu, 15 Apr 2021 16:41:23 +0100
From:   Quentin Monnet <quentin@...valent.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Jianlin Lv <Jianlin.Lv@....com>, bpf@...r.kernel.org
Cc:     corbet@....net, ast@...nel.org, andrii@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, davem@...emloft.net, kuba@...nel.org,
        illusionist.neo@...il.com, linux@...linux.org.uk,
        zlim.lnx@...il.com, catalin.marinas@....com, will@...nel.org,
        paulburton@...nel.org, tsbogend@...ha.franken.de,
        naveen.n.rao@...ux.ibm.com, sandipan@...ux.ibm.com,
        mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        luke.r.nels@...il.com, xi.wang@...il.com, bjorn@...nel.org,
        paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, iii@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, borntraeger@...ibm.com, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, x86@...nel.org, hpa@...or.com, udknight@...il.com,
        mchehab+huawei@...nel.org, dvyukov@...gle.com, maheshb@...gle.com,
        horms@...ge.net.au, nicolas.dichtel@...nd.com,
        viro@...iv.linux.org.uk, masahiroy@...nel.org,
        keescook@...omium.org, tklauser@...tanz.ch, grantseltzer@...il.com,
        irogers@...gle.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
        linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
        iecedge@...il.com
Subject: Re: [PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode

2021-04-15 16:37 UTC+0200 ~ Daniel Borkmann <daniel@...earbox.net>
> On 4/15/21 11:32 AM, Jianlin Lv wrote:
>> For debugging JITs, dumping the JITed image to kernel log is discouraged,
>> "bpftool prog dump jited" is much better way to examine JITed dumps.
>> This patch get rid of the code related to bpf_jit_enable=2 mode and
>> update the proc handler of bpf_jit_enable, also added auxiliary
>> information to explain how to use bpf_jit_disasm tool after this change.
>>
>> Signed-off-by: Jianlin Lv <Jianlin.Lv@....com>

Hello,

For what it's worth, I have already seen people dump the JIT image in
kernel logs in Qemu VMs running with just a busybox, not for kernel
development, but in a context where buiding/using bpftool was not
possible. Maybe not a common case, but still, removing the debugging
mode will make that impossible. Is there a particular incentive to
remove the feature?

Best regards,
Quentin