netdev - Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <991d74e8bac9a778ea0e0a4c522613ef39f8819e.camel@kernel.org>
Date:   Thu, 15 Apr 2021 16:51:23 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, michael.chan@...adcom.com, leon@...nel.org,
        ecree.xilinx@...il.com, habetsm.xilinx@...il.com,
        f.fainelli@...il.com, andrew@...n.ch, mkubecek@...e.cz,
        ariela@...dia.com
Subject: Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics

On Thu, 2021-04-15 at 15:53 -0700, Jakub Kicinski wrote:
> This set adds uAPI for reporting standard FEC statistics, and
> implements it in a handful of drivers.
> 
> The statistics are taken from the IEEE standard, with one
> extra seemingly popular but not standard statistics added.
> 
> The implementation is similar to that of the pause frame
> statistics, user requests the stats by setting a bit
> (ETHTOOL_FLAG_STATS) in the common ethtool header of
> ETHTOOL_MSG_FEC_GET.
> 
> Since standard defines the statistics per lane what's
> reported is both total and per-lane counters:
> 
>  # ethtool -I --show-fec eth0
>  FEC parameters for eth0:
>  Configured FEC encodings: None
>  Active FEC encoding: None
>  Statistics:
>   corrected_blocks: 256
>     Lane 0: 255
>     Lane 1: 1
>   uncorrectable_blocks: 145
>     Lane 0: 128
>     Lane 1: 17
> 
> v2: check for errors in mlx5 register access
> 
> Jakub Kicinski (6):
>   ethtool: move ethtool_stats_init
>   ethtool: fec_prepare_data() - jump to error handling
>   ethtool: add FEC statistics
>   bnxt: implement ethtool::get_fec_stats
>   sfc: ef10: implement ethtool::get_fec_stats
>   mlx5: implement ethtool::get_fec_stats

For the series:

Reviewed-by: Saeed Mahameed <saeedm@...dia.com>