netdev - Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1aadef14-f89e-ab08-84aa-a027425d26c0@ti.com>
Date:   Fri, 16 Apr 2021 13:11:19 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
CC:     Ioana Ciornei <ioana.ciornei@....com>,
        Vadym Kochan <vkochan@...vell.com>,
        Taras Chornyi <tchornyi@...vell.com>,
        Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        Ivan Vecera <ivecera@...hat.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-omap@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local
 flag in FDB notifications



On 14/04/2021 19:52, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> As explained in bugfix commit 6ab4c3117aec ("net: bridge: don't notify
> switchdev for local FDB addresses") as well as in this discussion:
> https://lore.kernel.org/netdev/20210117193009.io3nungdwuzmo5f7@skbuf/
> 
> the switchdev notifiers for FDB entries managed to have a zero-day bug,
> which was that drivers would not know what to do with local FDB entries,
> because they were not told that they are local. The bug fix was to
> simply not notify them of those addresses.
> 
> Let us now add the 'is_local' bit to bridge FDB entries, and make all
> drivers ignore these entries by their own choice.
> 
> Co-developed-by: Tobias Waldekranz <tobias@...dekranz.com>
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>   drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c        | 4 ++--
>   drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 2 +-
>   drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c   | 5 +++--
>   drivers/net/ethernet/rocker/rocker_main.c                  | 4 ++--
>   drivers/net/ethernet/ti/am65-cpsw-switchdev.c              | 4 ++--
>   drivers/net/ethernet/ti/cpsw_switchdev.c                   | 4 ++--
>   include/net/switchdev.h                                    | 1 +
>   net/bridge/br_switchdev.c                                  | 3 +--
>   net/dsa/slave.c                                            | 2 +-
>   9 files changed, 15 insertions(+), 14 deletions(-)

For cpsw:
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

Thank you.

-- 
Best regards,
grygorii