netdev - Re: [PATCH v7 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210416094006.70661f47@hermes.local>
Date:   Fri, 16 Apr 2021 09:40:06 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     davem@...emloft.net, kuba@...nel.org, kys@...rosoft.com,
        haiyangz@...rosoft.com, sthemmin@...rosoft.com, wei.liu@...nel.org,
        liuwe@...rosoft.com, netdev@...r.kernel.org, leon@...nel.org,
        andrew@...n.ch, bernd@...rovitsch.priv.at, rdunlap@...radead.org,
        shacharr@...rosoft.com, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org
Subject: Re: [PATCH v7 net-next] net: mana: Add a driver for Microsoft Azure
 Network Adapter (MANA)

On Thu, 15 Apr 2021 23:07:05 -0700
Dexuan Cui <decui@...rosoft.com> wrote:

> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 7349a70af083..f682a5572d84 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -2297,6 +2297,7 @@ static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev)
>  {
>  	struct device *parent = vf_netdev->dev.parent;
>  	struct net_device_context *ndev_ctx;
> +	struct net_device *ndev;
>  	struct pci_dev *pdev;
>  	u32 serial;
>  
> @@ -2319,8 +2320,17 @@ static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev)
>  		if (!ndev_ctx->vf_alloc)
>  			continue;
>  
> -		if (ndev_ctx->vf_serial == serial)
> -			return hv_get_drvdata(ndev_ctx->device_ctx);
> +		if (ndev_ctx->vf_serial != serial)
> +			continue;
> +
> +		ndev = hv_get_drvdata(ndev_ctx->device_ctx);
> +		if (ndev->addr_len != vf_netdev->addr_len ||
> +		    memcmp(ndev->perm_addr, vf_netdev->perm_addr,
> +			   ndev->addr_len) != 0)
> +			continue;
> +
> +		return ndev;
> +
>  	}
>  
>  	netdev_notice(vf_netdev,


This probably should be a separate patch.
I think it is trying to address the case of VF discovery in Hyper-V/Azure where the reported
VF from Hypervisor is bogus or confused.