netdev - Re: [PATCH v3 net-next 06/10] net: korina: Only pass mac address via platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210416065442.GA5082@alpha.franken.de>
Date:   Fri, 16 Apr 2021 08:54:42 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 06/10] net: korina: Only pass mac address via
 platform data

On Fri, Apr 16, 2021 at 01:30:04AM +0200, Andrew Lunn wrote:
> On Thu, Apr 15, 2021 at 01:06:43AM +0200, Thomas Bogendoerfer wrote:
> > Get rid of access to struct korina_device by just passing the mac
> > address via platform data and use drvdata for passing netdev to remove
> > function.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > ---
> >  arch/mips/rb532/devices.c     |  5 +++--
> >  drivers/net/ethernet/korina.c | 11 ++++++-----
> >  2 files changed, 9 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c
> > index dd34f1b32b79..5fc3c8ee4f31 100644
> > --- a/arch/mips/rb532/devices.c
> > +++ b/arch/mips/rb532/devices.c
> > @@ -105,6 +105,9 @@ static struct platform_device korina_dev0 = {
> >  	.name = "korina",
> >  	.resource = korina_dev0_res,
> >  	.num_resources = ARRAY_SIZE(korina_dev0_res),
> > +	.dev = {
> > +		.platform_data = &korina_dev0_data.mac,
> > +	}
> 
> This is a bit unusual. Normally you define a structure in
> include/linux/platform/data/koriana.h, and use that.
> 
> What about the name? "korina0" How is that passed?

this is just for transition purpose. My DT patches remove this struct
completly.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]