netdev - Re: [PATCH] drivers: ipa: Fix missing IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPcG6v1wpiNVgeOkooN-8e+WP-pYcNfc48w9sMLqp-VFvg@mail.gmail.com>
Date:   Fri, 16 Apr 2021 10:46:46 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     zhuguangqing83@...il.com
Cc:     Alex Elder <elder@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler

On Fri, 16 Apr 2021 at 06:26, <zhuguangqing83@...il.com> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@...il.com>
>
> Coccinelle noticed:
> drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@...il.com>
> ---
>  drivers/net/ipa/ipa_smp2p.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Did you test it? There are several patches like this all over the tree
so it looks like "let's fix everything from Coccinelle" because you
ignored at least in some of the cases that the handler is not the
default primary one. I am not saying that the change is bad, but
rather it looks automated and needs more consideration.

Best regards,
Krzysztof
Best regards,
Krzysztof