[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YHvssTvheST9nE6d@shredder>
Date: Sun, 18 Apr 2021 11:24:17 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, andrew@...n.ch,
mkubecek@...e.cz, idosch@...dia.com, saeedm@...dia.com,
michael.chan@...adcom.com
Subject: Re: [PATCH net-next 0/9] ethtool: add uAPI for reading standard stats
On Fri, Apr 16, 2021 at 09:08:16AM -0700, Jakub Kicinski wrote:
> On Fri, 16 Apr 2021 18:44:26 +0300 Ido Schimmel wrote:
> > Given that you have now standardized these stats, do you plan to feed
> > them into some monitoring system?
>
> Yes and no, I'm only intending to replace the internal FB ethtool
> scraping script with these stats..
Cool
>
> > For example, Prometheus has an ethtool
> > exporter [1] and now I see that support is also being added to
> > node_exporter [2] where it really belongs. They obviously mentioned [3]
> > the problem with lack of standardization: "There is also almost no
> > standardization, so if you use multiple network card vendors, you have
> > to examine the data closely to find out what is useful to you and set up
> > your alerts and dashboards accordingly."
> >
> > [1] https://github.com/Showmax/prometheus-ethtool-exporter
> > [2] https://github.com/prometheus/node_exporter/pull/1832
> > [3] https://tech.showmax.com/2018/11/scraping-ethtool-data-into-prometheus/
>
> Wow, are you working with those projects? We should probably let them
> know about the patches.
I'm mostly a user, not a contributor (wrote some exporters of my own).
I'll drop a comment there once your patches are in net-next.
Powered by blists - more mailing lists