netdev - Re: [PATCH iproute2] rdma: stat: initialize ret in stat_qp_show_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YHwgvbu392PVbQOh@unreal>
Date:   Sun, 18 Apr 2021 15:06:21 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Andrea Claudi <aclaudi@...hat.com>
Cc:     linux-netdev <netdev@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2] rdma: stat: initialize ret in
 stat_qp_show_parse_cb()

On Sun, Apr 18, 2021 at 02:00:38PM +0200, Andrea Claudi wrote:
> On Sun, Apr 18, 2021 at 1:07 PM Leon Romanovsky <leon@...nel.org> wrote:
> >
> > On Wed, Apr 14, 2021 at 12:50:57AM +0200, Andrea Claudi wrote:
> > > In the unlikely case in which the mnl_attr_for_each_nested() cycle is
> > > not executed, this function return an uninitialized value.
> > >
> > > Fix this initializing ret to 0.
> > >
> > > Fixes: 5937552b42e4 ("rdma: Add "stat qp show" support")
> > > Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
> > > ---
> > >  rdma/stat.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/rdma/stat.c b/rdma/stat.c
> > > index 75d45288..3abedae7 100644
> > > --- a/rdma/stat.c
> > > +++ b/rdma/stat.c
> > > @@ -307,7 +307,7 @@ static int stat_qp_show_parse_cb(const struct nlmsghdr *nlh, void *data)
> > >       struct rd *rd = data;
> > >       const char *name;
> > >       uint32_t idx;
> > > -     int ret;
> > > +     int ret = 0;
> >
> > It should be MNL_CB_OK which is 1 and not 0.
> >
> > Thanks.
> >
> 
> Hi Leon, and thanks for pointing this out.
> As this is already merged, I'll submit a fix.

Thanks

> 
> Regards,
> Andrea
> 
> > >
> > >       mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
> > >       if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_DEV_NAME] ||
> > > --
> > > 2.30.2
> > >
> >
>