netdev - Re: [PATCH net-next 1/2] nexthop: Restart nexthop dump based on last dumped nexthop identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91838deb-c82d-444e-6a19-3926aeff87f2@gmail.com>
Date:   Sun, 18 Apr 2021 10:06:41 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, petrm@...dia.com,
        mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 1/2] nexthop: Restart nexthop dump based on last
 dumped nexthop identifier

On 4/16/21 8:55 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> Currently, a multi-part nexthop dump is restarted based on the number of
> nexthops that have been dumped so far. This can result in a lot of
> nexthops not being dumped when nexthops are simultaneously deleted:
> 
>  # ip nexthop | wc -l
>  65536
>  # ip nexthop flush
>  Dump was interrupted and may be inconsistent.
>  Flushed 36040 nexthops
>  # ip nexthop | wc -l
>  29496
> 
> Instead, restart the dump based on the nexthop identifier (fixed number)
> of the last successfully dumped nexthop:
> 
>  # ip nexthop | wc -l
>  65536
>  # ip nexthop flush
>  Dump was interrupted and may be inconsistent.
>  Flushed 65536 nexthops
>  # ip nexthop | wc -l
>  0
> 
> Reported-by: Maksym Yaremchuk <maksymy@...dia.com>
> Tested-by: Maksym Yaremchuk <maksymy@...dia.com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> ---
>  net/ipv4/nexthop.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>

Any reason not to put this in -net with a Fixes tag?