netdev - Re: [PATCH] net: sunrpc: xprt.c: fix shift-out-of-bounds in xprt_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5850f8a65c59436b607c9d1ac088402d14873577.camel@hammerspace.com>
Date:   Mon, 19 Apr 2021 16:58:05 +0000
From:   Trond Myklebust <trondmy@...merspace.com>
To:     "bfields@...ldses.org" <bfields@...ldses.org>,
        "fuzzybritches0@...il.com" <fuzzybritches0@...il.com>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>,
        "anna.schumaker@...app.com" <anna.schumaker@...app.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "chuck.lever@...cle.com" <chuck.lever@...cle.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "linux-kernel-mentees@...ts.linuxfoundation.org" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "syzbot+ba2e91df8f74809417fa@...kaller.appspotmail.com" 
        <syzbot+ba2e91df8f74809417fa@...kaller.appspotmail.com>
Subject: Re: [PATCH] net: sunrpc: xprt.c: fix shift-out-of-bounds in
 xprt_calc_majortimeo

On Mon, 2021-04-19 at 16:36 +0000, Kurt Manucredo wrote:
> Fix shift-out-of-bounds in xprt_calc_majortimeo().
> 
> UBSAN: shift-out-of-bounds in net/sunrpc/xprt.c:658:14
> shift exponent 536871232 is too large for 64-bit type 'long u
> 
> Reported-by: syzbot+ba2e91df8f74809417fa@...kaller.appspotmail.com
> Signed-off-by: Kurt Manucredo <fuzzybritches0@...il.com>
> ---
>  net/sunrpc/xprt.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
> index 691ccf8049a4..07128ac3d51d 100644
> --- a/net/sunrpc/xprt.c
> +++ b/net/sunrpc/xprt.c
> @@ -655,7 +655,10 @@ static unsigned long xprt_calc_majortimeo(struct
> rpc_rqst *req)
>         unsigned long majortimeo = req->rq_timeout;
>  
>         if (to->to_exponential)
> -               majortimeo <<= to->to_retries;
> +               if (to->to_retries >= sizeof(majortimeo) * 8)
> +                       majortimeo = to->to_maxval;
> +               else
> +                       majortimeo <<= to->to_retries;
>         else
>                 majortimeo += to->to_increment * to->to_retries;
>         if (majortimeo > to->to_maxval || majortimeo == 0)

I've already stated on the mailing list that I'm not accepting any
changes to xprt_calc_majortimeo() for this problem. There is a fix to
the NFS mount code that addresses this bounds issue, and that commit is
already being tested in linux-next.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@...merspace.com