netdev - Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading standard stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210419122007.33d7579b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 19 Apr 2021 12:20:07 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org,
        davem@...emloft.net, andrew@...n.ch, idosch@...dia.com,
        saeedm@...dia.com, michael.chan@...adcom.com
Subject: Re: [PATCH net-next v2 3/9] ethtool: add a new command for reading
 standard stats

On Sat, 17 Apr 2021 22:10:39 +0200 Michal Kubecek wrote:
> On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote:
> > Heh, I misunderstood your question. You're asking if the strings can be
> > queried from the command line.
> > 
> > No, I don't think so. We could add some form of "porcelain" command if
> > needed.  
> 
> We don't have such command but I think it would be useful. After all, as
> you pointed out, the request is already implemented at UAPI level so all
> we need is to make it available to user.
> 
> The syntax will be a bit tricky as some string sets are global and some
> per device. Out of
> 
>     ethtool --show-strings [devname] <setname>
>     ethtool --show-strings [devname] set <setname>
>     ethtool --show-strings <setname> [dev <devname>]
> 
> the third seems nicest but also least consistent with the rest of
> ethtool command line syntax. So probably one of the first two.

Hm. Tricky. Option 4 would be to add a sub-command for low-level
requests, to break with standard requests clearly?

ethtool --internals get-strset set X [dev Y]