netdev - Re: [PATCH net-next 2/3] net: ethernet: mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210419144341.159bde8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 19 Apr 2021 14:43:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, john@...ozen.org,
        nbd@....name, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        dqfext@...il.com, frank-w@...lic-files.de
Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote:
> On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote:
> > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote:  
> > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and
> > > stats to different workqueues") splits the workqueue per event type. Add
> > > a mutex to serialize updates.
> > > 
> > > Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> > > Reported-by: Frank Wunderlich <frank-w@...lic-files.de>
> > > Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>  
> > 
> > This driver doesn't set unlocked_driver_cb, why is it expected to take
> > any locks? I thought the contract is that caller should hold rtnl.  
> 
> No rtnl lock is held from the netfilter side, see:
> 
> 42f1c2712090 ("netfilter: nftables: comment indirect serialization of
> commit_mutex with rtnl_mutex")

All the tc-centric drivers but mlx5 depend on rtnl_lock, is there
something preventing them from binding to netfilter blocks?